fix: open url by browser error on windows

inhere · Jan 24, 2021 · 91c4c14 · 91c4c14
1 parent 93f35f8
commit 91c4c14
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/app/Helper/AppHelper.php b/app/Helper/AppHelper.php
@@ -93,15 +93,18 @@ public static function getLangFromENV(string $default = ''): string
     public static function openBrowser(string $pageUrl): void
     {
         if (Sys::isMac()) {
-            $cmd = 'open';
+            $cmd = "open \"{$pageUrl}\"";
         } elseif (Sys::isWin()) {
-            $cmd = 'cmd /c start';
+            // $cmd = 'cmd /c start';
+            $cmd = "start {$pageUrl}";
         } else {
-            $cmd = 'x-www-browser';
+            $cmd = "x-www-browser \"{$pageUrl}\"";
         }
 
         Show::info("Will open the page on browser:\n  $pageUrl");
-        Sys::execute($cmd . " \"{$pageUrl}\"");
+
+        Show::writeln("> $cmd");
+        Sys::execute($cmd);
     }
 
     /**