Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce RPC query parsing #949

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Aug 10, 2021

Closes #859

rust-peg had a release in April that solved some of the original issues we had with this. This PR is mostly just a copy/paste from #858.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from xla August 10, 2021 18:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #949 (8c5e9f6) into master (b3cd0b7) will increase coverage by 0.2%.
The diff coverage is 84.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #949     +/-   ##
========================================
+ Coverage    71.6%   71.9%   +0.2%     
========================================
  Files         203     203             
  Lines       16277   16550    +273     
========================================
+ Hits        11669   11911    +242     
- Misses       4608    4639     +31     
Impacted Files Coverage Δ
rpc/src/client/bin/main.rs 0.6% <0.0%> (-0.2%) ⬇️
rpc/src/query.rs 88.5% <97.0%> (+10.3%) ⬆️
rpc/src/endpoint/commit.rs 40.0% <0.0%> (-60.0%) ⬇️
rpc/src/endpoint/genesis.rs 40.0% <0.0%> (-60.0%) ⬇️
light-client/src/types.rs 29.2% <0.0%> (-0.3%) ⬇️
rpc/src/method.rs 28.8% <0.0%> (+0.2%) ⬆️
tendermint/src/node.rs 66.1% <0.0%> (+0.2%) ⬆️
tendermint/src/timeout.rs 84.9% <0.0%> (+1.8%) ⬆️
tendermint/src/signature.rs 60.5% <0.0%> (+4.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cd0b7...8c5e9f6. Read the comment docs.

@andynog
Copy link

andynog commented Aug 10, 2021

Tested the subscribe with NewBlock events and seems to work correctly

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

✔️ 👛 🎿 ⛰

xla
xla previously approved these changes Aug 18, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Copy link
Contributor Author

Sorry @xla, had to fix a minor merge conflict. See 8c5e9f6

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ⏫ 🍽 💢

@thanethomson thanethomson merged commit bbad6fa into master Aug 18, 2021
@thanethomson thanethomson deleted the thane/859-rpc-query-parsing branch August 18, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reintroduce query parsing for tendermint-rpc
4 participants