Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Implement Supervisor #905

Closed
wants to merge 1 commit into from
Closed

p2p: Implement Supervisor #905

wants to merge 1 commit into from

Conversation

xla
Copy link
Contributor

@xla xla commented Jun 13, 2021

Work In Progress

This is a placeholder PR to hold all the outstanding changes for the p2p work, will be broken apart further.

Stacked on top of #904

@xla xla self-assigned this Jun 13, 2021
Base automatically changed from xla/692-p2p-transport to master June 15, 2021 11:29
Signed-off-by: Alexander Simmerl <a.simmerl@gmail.com>
@thanethomson
Copy link
Contributor

I've been looking through the abstractions again in the p2p/src/transport.rs module, and wanted to ask if there's a particular reason why "read/write" and "send/receive" naming conventions are mixed in the P2P architecture?

For example, the Connection trait has StreamRead and StreamSend associated types (instead of StreamRead/StreamWrite or StreamSend/StreamReceive).

@xla
Copy link
Contributor Author

xla commented Jul 27, 2021

For example, the Connection trait has StreamRead and StreamSend associated types (instead of StreamRead/StreamWrite or StreamSend/StreamReceive).

In order to distinguish physical connection semantics I'm keen on using send/receive for streams. The inconsistency you are pointing out is definitely an oversight and needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants