Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testgen external commands #549

Merged
merged 20 commits into from
Sep 11, 2020
Merged

Testgen external commands #549

merged 20 commits into from
Sep 11, 2020

Conversation

andrey-kuprianov
Copy link
Contributor

Part 4 of #529. See also #414. Add to Testgen utilities to simplify calling external commands, and also specifically to call the Apalache model checker, and JSON Artifact Translator (jsonatr).

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@andrey-kuprianov
Copy link
Contributor Author

Please review this one after #547 is merged -- there is a dependency.

romac
romac previously approved these changes Sep 10, 2020
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple nitpicks :)

testgen/src/apalache.rs Outdated Show resolved Hide resolved
testgen/src/apalache.rs Outdated Show resolved Hide resolved
testgen/src/command.rs Show resolved Hide resolved
@andrey-kuprianov
Copy link
Contributor Author

@romac I've addressed your suggestions; nice:) Could you please take a look and merge if everything is ok? Thanks!

@romac romac merged commit 598a72a into master Sep 11, 2020
@romac romac deleted the andrey/mbt-testgen-commandds branch September 11, 2020 10:07
@andrey-kuprianov andrey-kuprianov linked an issue Sep 11, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop a set of model-based tests for the LightClient
2 participants