feat(rpc): expose reqwest client #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiserKarel
force-pushed
the
expose-reqwest-client
branch
2 times, most recently
from
67646cb
to
10a92cc
Compare
Previously, the reqwest client for HttpClient would be unconditionally built by the internal builder, meaning that useful middleware such as tower could not be applied. This commits adds two ways to create the HttpClient with a custom reqwest::Client, either through new_from_parts, or using the builder.
KaiserKarel
force-pushed
the
expose-reqwest-client
branch
from
10a92cc
to
4c8abd5
Compare
|
@KaiserKarel Looks great, thanks for the PR! Can you please add a changelog entry for this, mentioning the new |
|
Don't worry about the failure on nightly, I'll take care of it. |
romac
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the reqwest client for HttpClient would be unconditionally built by the internal builder, meaning that useful middleware such as tower could not be applied.
This commits adds two ways to create the HttpClient with a custom reqwest::Client, either through new_from_parts, or using the builder.
.changelog/