Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tendermint-testgen: Add app_hash field to Header #1344

Merged
merged 10 commits into from
Sep 15, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Aug 29, 2023

Closes: #1343

Use case: informalsystems/hermes#3566

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review August 29, 2023 02:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #1344 (b79e0d3) into main (c2b5c9e) will increase coverage by 1.0%.
Report is 2 commits behind head on main.
The diff coverage is 48.1%.

❗ Current head b79e0d3 differs from pull request most recent head c621426. Consider uploading reports for the commit c621426 to get more accurate results

@@           Coverage Diff           @@
##            main   #1344     +/-   ##
=======================================
+ Coverage   59.3%   60.3%   +1.0%     
=======================================
  Files        273     272      -1     
  Lines      27095   26528    -567     
=======================================
- Hits       16068   16010     -58     
+ Misses     11027   10518    -509     
Files Changed Coverage Δ
proto/src/lib.rs 100.0% <ø> (ø)
testgen/src/header.rs 76.8% <23.5%> (-6.3%) ⬇️
p2p/src/secret_connection.rs 85.5% <50.0%> (-0.3%) ⬇️
testgen/src/light_block.rs 86.5% <100.0%> (-0.5%) ⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tendermint/src/hash.rs Outdated Show resolved Hide resolved
p2p/src/secret_connection.rs Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
testgen/src/light_block.rs Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
testgen/src/header.rs Outdated Show resolved Hide resolved
Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
@mzabaluev mzabaluev merged commit ff7a864 into main Sep 15, 2023
23 checks passed
@mzabaluev mzabaluev deleted the farhad/testgen-app-hash branch September 15, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce app_hash field in testgen Header
3 participants