release: v0.29.0

[erwanor]

Hey there, this fixes #1263 :)

• Referenced an issue explaining the need for the change
• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Added entry in .changelog/

[thanethomson]

Thanks very much for this @erwanor!

There are a couple of places on this branch where the html_root_url version hasn't been updated to v0.29.0:

• tendermint/src/lib.rs
• light-client/src/lib.rs
• p2p/src/lib.rs

Also, note that pushing a v0.29.0 tag will not yet automatically build and push the crates to crates.io - this is still quite a manual process that involves running the release.sh script from the root of the repo.

We still need a GitHub workflow to do this (please speak to @hdevalence about this, as I shared details a few days ago about what we need there).

[erwanor]

@thanethomson Thanks for catching those, I'll update the docs!

[thanethomson]

Ah, and I just noticed you're missing the .changelog/v0.29.0 folder.

[erwanor]

@thanethomson re: release.sh do I have the appropriate permissions to push to crates.io once this PR gets approved? or is this something you would need to run yourself? I can sync with henry about how we can help there, but I'm wondering if there's a ticket or convo that scopes the need (is there a blocker?)

[tarcieri]

Note: if you’re using docs.rs, setting html_root_url manually is obsolete: rust-lang/api-guidelines#229

[codecov-commenter]

Codecov Report

Merging #1267 (1c29869) into main (89c8add) will decrease coverage by 0.1%.
The diff coverage is n/a.

❗ Current head 1c29869 differs from pull request most recent head a65df6b. Consider uploading reports for the commit a65df6b to get more accurate results

@@           Coverage Diff           @@
##            main   #1267     +/-   ##
=======================================
- Coverage   64.3%   64.3%   -0.1%     
=======================================
  Files        250     250             
  Lines      21618   21618             
=======================================
- Hits       13917   13916      -1     
- Misses      7701    7702      +1     

Impacted Files	Coverage Δ
light-client/src/lib.rs	100.0% <ø> (ø)
proto/src/lib.rs	100.0% <ø> (ø)
tendermint/src/lib.rs	100.0% <ø> (ø)
testgen/src/vote.rs	84.1% <0.0%> (-0.9%)	⬇️
testgen/src/header.rs	83.5% <0.0%> (-0.6%)	⬇️
abci/src/server.rs	9.4% <0.0%> (+0.1%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[thanethomson]

re: release.sh do I have the appropriate permissions to push to crates.io once this PR gets approved?

No, I've just pushed #1268 to attempt to help with this. We've configured our @bftbot to be able to push crates on our behalf when you push tags to the repo. Please double-check my approach in #1268 to see if I've missed anything important?

If we can merge #1268 first, then this PR, then if you push the v0.29.0 tag to the repo it should trigger the release. Please also sign and annotate the tag before pushing it:

git tag -s -a v0.29.0 -m 'Release v0.29.0'

I usually manually create a release from a new tag. Eventually we'll automate that too.

Note: if you’re using docs.rs, setting html_root_url manually is obsolete: rust-lang/api-guidelines#229

Thanks for the heads-up @tarcieri!

[thanethomson]

Please edit point (3) above to make it a single sentence.

[thanethomson]

Suggested change

	This release features modularity improvements for the cryptographic routines, as well as fixes related to block verification and the use of consensus-friendly ed25519 crate.
	This release features modularity improvements for the cryptographic routines, as well as fixes related to block verification and the use of a consensus-friendly ed25519 crate.

[thanethomson]

To match the generated changelog.

[thanethomson]

🎉