-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic AppState
for genesis()
#1107
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- `[tendermint-rpc]` Allow users to specify the `AppState` type in the `Client::genesis()` function. | ||
([#1106](https://github.com/informalsystems/tendermint-rs/issues/1106)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,41 @@ | ||
//! `/genesis` endpoint JSON-RPC wrapper | ||
|
||
use serde::{Deserialize, Serialize}; | ||
use core::{fmt, marker::PhantomData}; | ||
|
||
use serde::{de::DeserializeOwned, Deserialize, Serialize}; | ||
use tendermint::Genesis; | ||
|
||
/// Get the genesis state for the current chain | ||
#[derive(Clone, Debug, Deserialize, Eq, PartialEq, Serialize)] | ||
pub struct Request; | ||
pub struct Request<AppState>(#[serde(skip)] PhantomData<AppState>); | ||
|
||
impl crate::Request for Request { | ||
type Response = Response; | ||
impl<AppState> Default for Request<AppState> { | ||
fn default() -> Self { | ||
Self(PhantomData) | ||
} | ||
} | ||
|
||
impl<AppState> crate::Request for Request<AppState> | ||
where | ||
AppState: fmt::Debug + Serialize + DeserializeOwned + Send, | ||
{ | ||
type Response = Response<AppState>; | ||
|
||
fn method(&self) -> crate::Method { | ||
crate::Method::Genesis | ||
} | ||
} | ||
|
||
impl crate::SimpleRequest for Request {} | ||
impl<AppState> crate::SimpleRequest for Request<AppState> where | ||
AppState: fmt::Debug + Serialize + DeserializeOwned + Send | ||
{ | ||
} | ||
|
||
/// Block responses | ||
#[derive(Clone, Debug, Deserialize, Serialize)] | ||
pub struct Response { | ||
pub struct Response<AppState> { | ||
/// Genesis data | ||
pub genesis: Genesis, | ||
pub genesis: Genesis<AppState>, | ||
} | ||
|
||
impl crate::Response for Response {} | ||
impl<AppState> crate::Response for Response<AppState> where AppState: Serialize + DeserializeOwned {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it would otherwise introduce a
Default
bound onAppState
.Now, did we expect the
app_state
property to be missing from the response sometimes? If so, then we should revert that change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think users might still be able to use an
Genesis<Option<AppState>>
as a workaround in such cases. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2c32896