chore(staking): update 0.47-lsm with staking changes [cherry pick] #2
Conversation
MSalopek
changed the base branch from
feat/v0.47.6-upgrade-lsm
to
feat/lsm/v0.47.x
MSalopek
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams" | ||
| Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend" | ||
| Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward" | ||
| Msg_WithdrawAllTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawAllTokenizeShareRecordReward" |
Check failure
Code scanning / Golang security checks by gosec
Potential hardcoded credentials Error
| Msg_FundCommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Msg/FundCommunityPool" | ||
| Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams" | ||
| Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend" | ||
| Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward" |
Check failure
Code scanning / Golang security checks by gosec
Potential hardcoded credentials Error
| @@ -29,6 +29,7 @@ | |||
| Query_DelegatorValidators_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorValidators" | |||
| Query_DelegatorWithdrawAddress_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorWithdrawAddress" | |||
| Query_CommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Query/CommunityPool" | |||
| Query_TokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Query/TokenizeShareRecordReward" | |||
Check failure
Code scanning / Golang security checks by gosec
Potential hardcoded credentials Error
| func (msg MsgWithdrawTokenizeShareRecordReward) GetSigners() []sdk.AccAddress { | ||
| owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| func (msg MsgWithdrawAllTokenizeShareRecordReward) GetSigners() []sdk.AccAddress { | ||
| owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| CommissionRates commission = 2 [(gogoproto.nullable) = false, (amino.dont_omitempty) = true]; | ||
| // Deprecated: This field has been deprecated with LSM in favor of the validator bond | ||
| string min_self_delegation = 3 [ | ||
| deprecated = true, |
There was a problem hiding this comment.
Add deprecated = true, and (gogoproto.nullable) = false to min_self_delegation in message MsgEditValidator below.
|
Closing on favor of #3 |
Co-authored-by: Philip Offtermatt <p.offtermatt@gmail.com>
Description
Related: cosmos#18200
The
feat/lsm/v0.47.xis pointing atrelease/v0.47.x@55c6d55c5583bacd37f6ddbe60570688edb81d76.This PR brings cosmos#18313 to this repo to make it easier to finalize the upgrade.
Credits: @zmanian
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change