block pushes on non-clean git repos #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewwells
force-pushed
the
diffBeforePush
branch
from
dae3a0c
to
f08e901
Compare
kd7lxl
reviewed
May 5, 2021
| @@ -78,7 +78,9 @@ push-atlas: docker | |||
| ifndef IMAGE_REGISTRY | |||
| @(echo "Please set IMAGE_REGISTRY variable in Makefile.vars to use push command"; exit 1) | |||
| else | |||
| @docker push $(SERVER_IMAGE):$(IMAGE_VERSION) | |||
| # Verify no changes locally prior to pushing image | |||
| git diff --exit-code | |||
There was a problem hiding this comment.
This might not work as expected, because the flag file could be stale. The way this makefile was implemented doesn't check for a stale docker build context like basic docker build does.
If this section is removed, docker will ensure the image is based on the current context, which in turn will make the output of git diff --exit-code useful for matching the image to the commit.
atlas-cli/atlas/templates/Makefile.common.gotmpl
Lines 70 to 75 in f08e901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.