Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebookbug ipmi lowercase change #919

Merged
merged 2 commits into from
Mar 29, 2016
Merged

Ebookbug ipmi lowercase change #919

merged 2 commits into from
Mar 29, 2016

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Mar 23, 2016

No description provided.

@sparrc sparrc force-pushed the ebookbug-master branch 2 times, most recently from b31f0f7 to 98fb22d Compare March 23, 2016 15:51
@sparrc
Copy link
Contributor Author

sparrc commented Mar 23, 2016

hi @ebookbug, could you take a look at this? I have made some changes to add unit tests, to add a "units" tag, to convert everything to lowercase, and to convert spaces to "_"

can you let me know what you think of doing this? I thought it might make it easier and more consistent to query in the db?

@sparrc
Copy link
Contributor Author

sparrc commented Mar 23, 2016

Would also be OK with me if we only translated " " to "_", we don't need to do the lower casing if you'd rather not

@sparrc sparrc force-pushed the ebookbug-master branch 2 times, most recently from ba0ab94 to e60072a Compare March 23, 2016 20:12
@ebookbug
Copy link
Contributor

Tansform to lower case is ok.
I think it will be better to take the unit (for example rpm,watt) to be a field.

@sparrc
Copy link
Contributor Author

sparrc commented Mar 24, 2016

Can you explain why you would prefer units as a field instead of a tag?

@ebookbug
Copy link
Contributor

This is no need to index the unit

@sparrc
Copy link
Contributor Author

sparrc commented Mar 28, 2016

@ebookbug I see your point...it certainly seems like it makes more sense as a field for influxdb. There are other outputs though where it makes more sense as a tag (graphite, opentsdb, prometheus, etc.)

how would you feel if the schema design actually looked more like this (would this be too difficult to query?):

ipmi_sensor,server=10.20.2.203 ambient_temp_degrees_c=20,ambient_temp_status=1,altitude_feet=80, altitude_status=1, ....

@sparrc
Copy link
Contributor Author

sparrc commented Mar 28, 2016

One other thing to consider-- if units is a tag that doesn't change for that particular sensor name, then it doesn't change the cardinality, and thus there is no penalty to indexing it.

So I'm leaning towards leaving it as-is, as a tag

@ebookbug
Copy link
Contributor

Different manufacture‘s server maybe have different metrics.
So,it's not a good idea to write all the metric in one line.

But in next build,we can seperate the measurement ipmi_sensor to some sub measurements ,such as ipmi_temp,ipmi_fan_speed,ipmi_voltage ....

@ebookbug
Copy link
Contributor

It's a common issue to discuss where to place the unit
I think the unit(rpm,watt) and counter type(gauge,count) should be designed in the schema when using influxdb,not stored in the tags nor the fields

@sparrc sparrc force-pushed the ebookbug-master branch 4 times, most recently from 2d4e436 to 8beacf9 Compare March 29, 2016 17:22
@sparrc sparrc merged commit 21ece2d into master Mar 29, 2016
@sparrc sparrc deleted the ebookbug-master branch March 30, 2016 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants