add database name in azure Managed instance. query version 2 is worki… #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Vm sqlserver instacnes but not in Manged instances, it returned Guid. INSERT INTO @PCounters SELECT DISTINCT RTrim(spi.object_name) object_name, RTrim(spi.counter_name) counter_name, RTrim(isnull(d.name,spi.instance_name) instance_name, CAST(spi.cntr_value AS BIGINT) AS cntr_value, spi.cntr_type FROM sys.dm_os_performance_counters AS spi LEFT OUTER JOIN sys.databases AS d ON spi.instance_name = d.physical_database_name
|
@denzilribeiro Can you review? |
|
There are some other caveats into it too for master physical_db_name is same as the database name for a Azure SQL DB ( single DB), can result in dup rows, will take a closer look at it and fix soon. This is not only a MI issue but also a single DB issue |
|
Should work now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng Vm sqlserver instacnes but not in Manged instances, it returned Guid.
INSERT INTO @PCounters
SELECT DISTINCT
RTrim(spi.object_name) object_name,
RTrim(spi.counter_name) counter_name,
RTrim(isnull(d.name,spi.instance_name) instance_name,
CAST(spi.cntr_value AS BIGINT) AS cntr_value,
spi.cntr_type
FROM sys.dm_os_performance_counters AS spi
LEFT OUTER JOIN sys.databases AS d ON spi.instance_name = d.physical_database_name
Required for all PRs: