Add MongoDB uptime_ms #6669
Merged
Add MongoDB uptime_ms #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/inputs/mongodb/mongostat.go
Outdated
| @@ -659,6 +661,8 @@ func NewStatLine(oldMongo, newMongo MongoStatus, key string, all bool, sampleSec | |||
| Faults: -1, | |||
| } | |||
|
|
|||
| returnVal.UptimeMillis = newStat.UptimeMillis | |||
There was a problem hiding this comment.
Looks good, but can you update the field to be in nanoseconds and rename the field to uptime_ns to match up with flushes_total_time_ns? See line 742
There was a problem hiding this comment.
I get it why it's better to name things consistently, but I have doubts:
- It may be misleading to have
_nssuffix on something that has millisecond resolution. - It's clearer for user when metric name matches with MongoDB's command output.
There was a problem hiding this comment.
These are good points but I'd still like to make this change for consistency. We are trying to do this across the board for all duration and time values and nanosecond precision gives us the most flexibility and is consistend with our timestamp format.
There was a problem hiding this comment.
Replaced uptime_ms with uptime_ns.
danielnelson
added
area/mongodb
feat
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB doc: serverstatus.uptimeMillis