feat: add -run-once option to exit after a single collection #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawkode
force-pushed
the
feature/serverless-telegraf
branch
2 times, most recently
from
3cf5b18
to
d0be50c
Compare
rawkode
force-pushed
the
feature/serverless-telegraf
branch
from
d0be50c
to
aaeee5e
Compare
|
Managed to clean this up a little more 👍 |
danielnelson
suggested changes
Nov 8, 2019
| } | ||
|
|
||
| // NewAgent returns an Agent for the given Config. | ||
| func NewAgent(config *config.Config) (*Agent, error) { | ||
| func NewAgent(config *config.Config, runOnce bool) (*Agent, error) { |
There was a problem hiding this comment.
The implementation of this isn't something I would accept, adding booleans as trailing parameters is not allowed and it pushes a lot of new complexity into the agent.
The interface to this should be a new function, similar to what was done with the Test function.
Implementation might be shared, but it ought to guarantee a single Gather, single Aggregation, and as many writes are are required to send it all. So, I'm not sure if sharing much would work out.
|
Let's reopen the pull request when we have something closer to what we would merge. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Decided to have a pop at #2546