-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ipmi status codes #5816
Fix/ipmi status codes #5816
Conversation
988cebf
to
1d9f7e0
Compare
Also, there's no need to force push on telegraf, we squash and merge so it ends up being one commit in the end. |
plugins/inputs/ipmi_sensor/ipmi.go
Outdated
description := ipmiFields["description"] | ||
|
||
// handle hex description field | ||
if description[:2] == "0x" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check length of description first to avoid panic
|
||
// handle hex description field | ||
if description[:2] == "0x" { | ||
descriptionInt, err := strconv.ParseInt(description, 0, 64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check error before using descriptionInt
1d9f7e0
to
4896a24
Compare
(cherry picked from commit b22bf01)
can you please update documentation for where to add hex value? Thanks |
@safadig This PR should allow hex values to be parsed from the output of |
@danielnelson I am trying to use the ipmi from a Dell iDRAC that has user; password, as well as a hex based encryption key to allow access. |
Got it. It won't be possible to pass this option right now, but I see your feature request #6858. |
@danielnelson, also need this feature. I believe it can be a set variable that can be commented or uncommented in the config file (similar to the privilege level variable) encryption Key = "number" |
Closes: #5755
This PR adds support for hex values in IPMI messages. It also adds unit tests for both version 1 & 2 parsing of IPMI messages.