Wavefront output enhancements #5161
Conversation
danielnelson
added
the
feat
| @@ -264,6 +269,7 @@ func TestBuildValueString(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Delete or update this test as appropriate.
There was a problem hiding this comment.
Should TestBuildValueString should remain since the functionality is deprecated but not removed yet?
Did delete commented out test below (TestFormatMetricPoint)
There was a problem hiding this comment.
We can remove TestBuildValueString once the option is removed, for now its best to leave it.
| /* | ||
| metricLine := formatMetricPoint(point, w) | ||
| _, err := connection.Write([]byte(metricLine)) | ||
| */ |
There was a problem hiding this comment.
Remove commented out code.
| @@ -246,6 +246,10 @@ | |||
| name = "github.com/vishvananda/netlink" | |||
| revision = "b2de5d10e38ecce8607e6b438b6d174f389a004e" | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/wavefronthq/wavefront-sdk-go" | |||
| version = "v0.9.0" | |||
There was a problem hiding this comment.
There should be some changes to Gopkg.lock as well, which is why the tests aren't working, just need to run dep ensure once.
| sender, err := wavefront.NewDirectSender(&wavefront.DirectConfiguration{ | ||
| Server: w.Url, | ||
| Token: w.Token, | ||
| FlushIntervalSeconds: 5, |
There was a problem hiding this comment.
Telegraf considers returning from Write() without error to be successful delivery of metrics, but with the extra layer of buffering we don't actually know if the metric was sent. There may be some reduction in durability because of this, might be worth considering a sender implementation that sends immediately without buffering?
Required for all PRs:
Updated connection and communication to use Wavefront's go-sdk. Benefits include:
Also marked string_to_number feature as deprecated since this is now done using the enum plugin. Goal is to remove it completely in Telegraf 2.