Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define custom name/display name when installing telegraf as a windows service #4753

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Define custom name/display name when installing telegraf as a windows service #4753

merged 3 commits into from
Sep 28, 2018

Conversation

Jaeyo
Copy link
Contributor

@Jaeyo Jaeyo commented Sep 26, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

close #4263

glinton
glinton suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this option to the usage output in internal/usage_windows.go, thanks

@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 26, 2018
@danielnelson danielnelson added this to the 1.9.0 milestone Sep 28, 2018
@danielnelson danielnelson merged commit 6b7d64f into influxdata:master Sep 28, 2018
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
@Jaeyo @rgitzel
Add ability to define a custom service name when installing as a Wind…
5947e1d 
…ows service (influxdata#4753)
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@Jaeyo @otherpirate
Add ability to define a custom service name when installing as a Wind…
0c31d31 
…ows service (influxdata#4753)
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@Jaeyo @otherpirate
Add ability to define a custom service name when installing as a Wind…
052d8ad 
…ows service (influxdata#4753)
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@Jaeyo
Add ability to define a custom service name when installing as a Wind…
6a9c1a9 
…ows service (influxdata#4753)
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@Jaeyo
Add ability to define a custom service name when installing as a Wind…
bb290c7 
…ows service (influxdata#4753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Define custom name/display name when installing telegraf as a windows service
3 participants
@Jaeyo @glinton @danielnelson