Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http path configuration for OpenTSDB plugin #4347

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Jun 26, 2018

This PR updates the OpenTSDB to allow for the path to be configured when using the HTTP client. Currently there is no way for telegraf to send data to OpenTSDB servers behind a reverse proxy with non default routes.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@@ -123,7 +124,7 @@ func (o *openTSDBHttp) flush() error {
Scheme: o.Scheme,
User: o.User,
Host: fmt.Sprintf("%s:%d", o.Host, o.Port),
Path: "/api/put",
Path: o.Path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you default o.Path to "/api/put" in order to not break any current implementations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This should be all set now

@danielnelson danielnelson added this to the 1.8.0 milestone Jul 2, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 2, 2018
@danielnelson danielnelson merged commit c7cfc2e into influxdata:master Jul 2, 2018
@danielnelson
Copy link
Contributor

After merging I switched the config to use snake_case format, either format will work for now since there is no field tags but this is the preferred style. 2ee374c

rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants