Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopK processor: Add topk processor plugin code #4096

Merged
merged 2 commits into from
May 5, 2018

Conversation

mirath
Copy link
Contributor

@mirath mirath commented May 3, 2018

The pluging uses:

  • Selectors to pick the metrics that will be filtered
  • A group by clause to group the metrics based on metric names and tags
  • A list of fields
  • An aggregator function to agreggate each field of the grouped metrics
  • Once the aggregations for each group are calculated, the plugin orders the groups by each aggregation and returns all the metrics of each group in the top k spots

PR #3691 closed in favor of this one, as I mangled the branch through a rebase

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@mirath
Copy link
Contributor Author

mirath commented May 3, 2018

@danielnelson New PR

@russorat russorat added this to the 1.7.0 milestone May 3, 2018
@danielnelson danielnelson merged commit ac9b308 into influxdata:master May 5, 2018
@danielnelson
Copy link
Contributor

Merged! 🎉

jvrahav pushed a commit to jvrahav/telegraf that referenced this pull request May 9, 2018
arkady-emelyanov pushed a commit to arkady-emelyanov/telegraf that referenced this pull request May 18, 2018
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@mapleleafs89
Copy link

Is there any prebuilt solution to integrate this topk plugin data into Grafana dashboard or is anyone willing to? I use the telegraf-system-dashboard but it hasn't been updated in roughly a year :(

@glinton
Copy link
Contributor

glinton commented Sep 21, 2018

@mapleleafs89 You might have better luck asking on the community page

@PauloTemenos
Copy link

Just found this plugin. Really cool stuff and (possibly) exactly what I need.

However, it is unclear what is this processor actually doing to the data + it is unclear how to actually use that processor...

Can anything be done abou tit? Maybe update the MD file to include an example(s) config and an example of what data might look like before passing through the processor and after passing through the processor?

@glinton
Copy link
Contributor

glinton commented Nov 16, 2018

@PauloTemenos can you open a new issue for the requested documentation additions, please? Thanks

@PauloTemenos
Copy link

@glinton
Feature request opened here: #5005

Cheers.

otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants