Add Wireless Input plugin #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielnelson anything that can be improved here? Been using this since February in production. |
glinton
reviewed
Jul 23, 2018
plugins/inputs/wireless/wireless.go
Outdated
| fields := strings.Fields(string(lines[i])) | ||
| var values []int64 | ||
| for i := 1; i < len(fields); i = i + 1 { | ||
| v, err := strconv.ParseInt(strings.Trim(fields[i], "."), 10, 64) |
There was a problem hiding this comment.
No need to strings.Trim because strings.Fields handles this.
|
@jamesmaidment do you think you can update so the tests pass then we can merge this |
|
Similar to #3650 |
|
@glinton fixed now |
glinton
approved these changes
Sep 21, 2018
danielnelson
suggested changes
Oct 11, 2018
danielnelson
approved these changes
Oct 29, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
The wireless plugin gathers metrics about wireless link quality by reading the
/proc/net/wirelessfile. This plugin currently supports linux only.