Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2099 -- Add GCP Stackdriver support to telegraf. #3774

Closed

Conversation

derrley
Copy link

@derrley derrley commented Feb 8, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests. -- not yet.

This is my first PR -- looking to get some feedback on the direction of this. We've got it running in our own environment with mostly successful results, but I know others might have different environments. In the mean time, I'm going to be working on unit tests and beefing up the README. The example config should make the features fairly clear.

@derrley derrley force-pushed the derrley/2099-GCP-Stackdriver branch from 4f45b2a to 31e61a1 Compare February 8, 2018 17:29
@danielnelson
Copy link
Contributor

Thanks for the pull request @derrley, I'll try to take a closer look soon, probably during the 1.7 cycle.

@danielnelson danielnelson added this to the 1.7.0 milestone Feb 9, 2018
@russorat
Copy link
Contributor

@derrley thanks so much for this PR! Do you mind providing a little more information about your use case and how you use this in your environment?

@russorat russorat removed the triage label Mar 22, 2018
@JanekLehr
Copy link

@russorat
I worked with @derrley while he was developing this plugin. We run a TICK stack in Google Kubernetes Engine, and one of the telegraf instances scrapes Stackdriver metrics and sends them to InfluxDB. Currently the only Kapacitor alert that uses these metrics is one to alert when a pod container was OOMKilled, but it also gives us the ability to track latencies of our HTTP Load Balancer in GCP, and other GCP resource metrics.

By doing this we can have all our alerts in one place (kapacitor) and avoid defining, and paying for, alerts in Stackdriver

Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Add some tests, a readme, and attend to the requested changes and we'll get this merged.

Godeps Show resolved Hide resolved
case metricpb.MetricDescriptor_STRING:
field = p.Value.GetStringValue()
default:
// TODO: AddError here? Is it really an error?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe either skip the metric, as you currently are, or default it to a chosen type.

@russorat russorat modified the milestones: 1.8.0, 1.9.0 Sep 4, 2018
@glinton
Copy link
Contributor

glinton commented Sep 17, 2018

@derrley Do you still have time available, and are you interested in continuing this?Thanks

@glinton glinton removed this from the 1.9.0 milestone Oct 26, 2018
@glinton glinton added this to the 1.10 milestone Oct 29, 2018
@danielnelson
Copy link
Contributor

Latest work is on #4977

@russorat russorat removed this from the 1.10.0 milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants