prometheus input: Remove credentials from URL before setting url tag #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercase to not overwrite net/url package, run gofmt
|
circleci test fail of TestTailBadLine has nothing to do with this pull request. On my local system the failed test runs through. Any ideas? |
danielnelson
reviewed
Feb 2, 2018
plugins/inputs/prometheus/README.md
Outdated
| @@ -67,7 +67,7 @@ Measurement names are based on the Metric Family and tags are created for each | |||
| label. The value is added to a field named based on the metric type. | |||
|
|
|||
| All metrics receive the `url` tag indicating the related URL specified in the | |||
| Telegraf configuration. If using Kubernetes service discovery the `address` | |||
| Telegraf configuration. Existing username and password for basic authentication will be removed before. If using Kubernetes service discovery the `address` | |||
There was a problem hiding this comment.
Let's remove this, we shouldn't have to say this because doing it the other way would be bad. BTW, using the userinfo section of the url is not basic auth.
There was a problem hiding this comment.
Oh sorry, you are right, this is not basic auth! I red it in the referenced issue and wasn't think about it when writing the commit message and Readme.
I'll remove the sentence in Readme.md with next commit.
phlipse
changed the title
|
I don't know what you have done but it fixed the failing test TestTailBadLine. :) |
danielnelson
pushed a commit
that referenced
this pull request
Feb 5, 2018
(cherry picked from commit b7a68ee)
mkboudreau
added a commit
to mkboudreau/telegraf
that referenced
this pull request
Feb 16, 2018
* master: (59 commits) Added additional SQL Server performance counters (influxdata#3770) Update changelog Fix ping plugin not reporting zero durations (influxdata#3778) Adjust time of nightly build Update changelog Add TLS support to the mesos input plugin (influxdata#3769) Install new requirements for fpm gem install Update changelog Add additional metrics and reverse metric names option to openldap (influxdata#3722) Update paho mqtt to latest release Update changelog Remove userinfo from url tag in prometheus input (influxdata#3743) Update sample config in contributing docs Run nightly build sequentially Fix Makefile on Windows and use in AppVeyor build (influxdata#3748) Fix example source_override values in wavefront output (influxdata#3744) Update gitignore Update changelog Improve procstat readme Add native Go method for finding pids to procstat (influxdata#3559) ...
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove user data from URL before setting URL tag to prevent information disclosure.
See #3739.
Also run gofmt and turn variables with name url to uppercase to prevent overwrite of net/url package. Now it is more clear wheter the variable or package is used.
Required for all PRs: