Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping plugin: Add cases to interface parameter #3726

Merged
merged 1 commit into from
Jan 29, 2018
Merged

ping plugin: Add cases to interface parameter #3726

merged 1 commit into from
Jan 29, 2018

Conversation

phlipse
Copy link
Contributor

@phlipse phlipse commented Jan 27, 2018

Fixes issue #3721.

Linux supports defining the source address or source interface with paramter I.
FreeBSD and Darwin do only support specifying the source address and also use a different parameter S to set it: see manpage.

This commit adds cases to support pings from a defined source address on other operating systems than Linux. Source interface is linux only.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@phlipse
Copy link
Contributor Author

phlipse commented Jan 27, 2018

Maybe the variable should be called Source instead of Interface? I will let take this decision to an official maintainer.

@danielnelson danielnelson added this to the 1.6.0 milestone Jan 29, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 29, 2018
@danielnelson danielnelson merged commit 1b84ac0 into influxdata:master Jan 29, 2018
@phlipse phlipse deleted the ping branch January 30, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants