Add input plugin for DC/OS #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goller
suggested changes
Nov 28, 2017
|
|
||
| resp, err := c.httpClient.Do(req.WithContext(ctx)) | ||
| if err != nil { | ||
| <-c.semaphore |
There was a problem hiding this comment.
Possibly add this to the defer above
plugins/inputs/dcos/client.go
Outdated
| return c.token.text | ||
| } | ||
|
|
||
| func (c *client) EnsureAuth(ctx context.Context) error { |
There was a problem hiding this comment.
Probably move ensureauth to a higher level and expose the login function publicly.
plugins/inputs/dcos/client.go
Outdated
| } | ||
|
|
||
| func (c *client) GetContainers(ctx context.Context, node string) ([]string, error) { | ||
| containers := []string{} |
There was a problem hiding this comment.
Make a type Containers []string
plugins/inputs/dcos/client.go
Outdated
| Title string | ||
| Description string | ||
| } | ||
| type Login struct { |
plugins/inputs/dcos/client.go
Outdated
| GetAppMetrics(ctx context.Context, node, container string) (*Metrics, error) | ||
| } | ||
|
|
||
| type Credentials struct { |
There was a problem hiding this comment.
Would be nice to have comments on structs
plugins/inputs/dcos/client.go
Outdated
| ExpiresAt: 0, | ||
| }, | ||
| }) | ||
| ss, err := token.SignedString(c.credentials.PrivateKey) |
plugins/inputs/dcos/dcos.go
Outdated
|
|
||
| func (d *DCOS) Gather(acc telegraf.Accumulator) error { | ||
| if !d.initialized { | ||
| err := d.createFilters() |
There was a problem hiding this comment.
put initialized in createFilters
plugins/inputs/dcos/dcos.go
Outdated
| } | ||
| } | ||
|
|
||
| results := []*point{} |
plugins/inputs/dcos/dcos.go
Outdated
| fieldKey = fieldKey + "_bytes" | ||
| } | ||
|
|
||
| tagset := []string{} |
plugins/inputs/dcos/dcos.go
Outdated
| fields := make(map[string]interface{}) | ||
| for k, v := range p.fields { | ||
| if strings.HasPrefix(k, "dcos_metrics_module_") { | ||
| k = strings.TrimPrefix(k, "dcos_metrics_module_") |
There was a problem hiding this comment.
Probably move this trim up above.
danielnelson
commented
Nov 28, 2017
plugins/inputs/dcos/client.go
Outdated
| return err | ||
| } | ||
| func (c *client) url(path string) string { | ||
| c.clusterURL.Path = path |
There was a problem hiding this comment.
Need to copy clusterURL before setting path.
|
I think everything is addressed except the struct comments. |
goller
approved these changes
Nov 29, 2017
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: