Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zipkin plugin #3080

Merged
merged 162 commits into from
Aug 3, 2017
Merged

Add Zipkin plugin #3080

merged 162 commits into from
Aug 3, 2017

Conversation

danielnelson
Copy link
Contributor

@danielnelson danielnelson commented Aug 1, 2017

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Adam Perlin and others added 30 commits July 24, 2017 14:50
Signed-off-by: Adam Perlin <adamperlin@seattleacademy.org>
Signed-off-by: Ayrdrie Palmer <ayrdriepalmer@gmail.com>
…or graceful

Refactor serve and shutdown methods
Remove unused channel
…tations necessary to unmarshal zipkin data
@adamperlin adamperlin mentioned this pull request Aug 2, 2017
…plugin

Meant to prevent an empty string from being added as part of a metric
Empty strings should not be added to telegraf's internal metrics
@danielnelson danielnelson merged commit 137b312 into master Aug 3, 2017
@danielnelson danielnelson deleted the zipkin branch August 3, 2017 18:54
@codefromthecrypt
Copy link

This looks cool! Do I get this right, that this is a zipkin http listener (ex that users can point existing apps at)? PS we just released our first major data model change (which sits alongside the other). openzipkin/zipkin-api#33

@danielnelson
Copy link
Contributor Author

Do I get this right, that this is a zipkin http listener (ex that users can point existing apps at)?

Yes

we just released our first major data model change

Thanks for the update, we should add support for the v2 api as well @goller

maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants