Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display error message if serve prometheus metric output failed #2984

Merged

Conversation

maximesong
Copy link
Contributor

@maximesong maximesong commented Jul 5, 2017

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

I encounter this issue when I have a telegraf instance A already bind prometheus metric endpoint to port 9216, while another telegraf instance B trying to bind port 9216 after that didn't show any clue its binding failed.

What makes it more confusing is that my visiting metrics endpoint at port 9216 still shows results. I didn't realize there's an old instance A there.

I think output error message from serve and listen method should be a help to this issue.

@danielnelson danielnelson added this to the 1.4.0 milestone Jul 5, 2017
@danielnelson danielnelson merged commit 0f85040 into influxdata:master Jul 5, 2017
@danielnelson
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants