adding option to randomize Kinesis partition key #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
suggested changes
Apr 25, 2017
plugins/outputs/kinesis/kinesis.go
Outdated
| ## If set the paritionKey will be a random UUID on every put. | ||
| ## This allows for scaling across multiple shards in a stream. | ||
| ## This will cause issues with ordering. | ||
| randomize_partitionKey = false |
There was a problem hiding this comment.
Rename to use_random_partitionkey. Mention that if this is set then partitionkey is ignored. Can you explain a little about the ordering issues (perhaps in the README)
Godeps
Outdated
| @@ -19,6 +19,7 @@ github.com/go-sql-driver/mysql 2e00b5cd70399450106cec6431c2e2ce3cae5034 | |||
| github.com/gobwas/glob bea32b9cd2d6f55753d94a28e959b13f0244797a | |||
| github.com/golang/protobuf 8ee79997227bf9b34611aee7946ae64735e6fd93 | |||
| github.com/golang/snappy 7db9049039a047d955fe8c19b83c8ff5abd765c7 | |||
| github.com/google/uuid 6a5e28554805e78ea6141142aba763936c4761c0 | |||
There was a problem hiding this comment.
I would like to use https://github.com/satori/go.uuid for uuids.
danielnelson
approved these changes
Apr 26, 2017
|
Great, just update the CHANGELOG. |
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
May 30, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: