Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gopsutil for FreeBSD disk time metrics #1534

Merged
merged 1 commit into from
Jul 22, 2016
Merged

update gopsutil for FreeBSD disk time metrics #1534

merged 1 commit into from
Jul 22, 2016

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Jul 22, 2016

I submitted a patch upstream to gopsutil to fix some diskio time issues on FreeBSD: shirou/gopsutil#232
The issue was that the read_time and write_time metrics on Linux were reported in milliseconds, but on FreeBSD they were in seconds. The io_time metric was also missing entirely. The upstream PR fixed both these issues.
While the io_time might be considered a feature, the inconsistent time units between Linux & FreeBSD I would consider a bug, and so I have classified this as a bug fix in the CHANGELOG.

This is all the upstream changes that will be pulled in: shirou/gopsutil@586bb69...ee66bc5

Required for all PRs:

  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Results in adding the io_time metric to FreeBSD, and adjusts the read_time and write_time metrics to be in milliseconds like linux.
@sparrc sparrc merged commit 4363eeb into influxdata:master Jul 22, 2016
@phemmer phemmer deleted the gopsutil-update branch July 22, 2016 14:55
bitmori pushed a commit to bitmori/telegraf that referenced this pull request Jul 23, 2016
Results in adding the io_time metric to FreeBSD, and adjusts the read_time and write_time metrics to be in milliseconds like linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants