Add support for self-signed certs to RabbitMQ input plugin #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2016 17:31
When using self-signed the metrics collection will fail, this will allow the user to specify in the input configuration file if they want to skip certificate verification. This is functionally identical to `curl -k` At some point this functionality should be moved to the agent as it is already implemented identically in several different input plugins.
These should be properly fleshed out at some point to ensure code completeness
mattyjones
changed the title
mattyjones
changed the title
|
@mattyjones there is a generic internal helper function for fully supporting self-signed certs. See the httpjson.go plugin for an example. |
|
@sparrc Thanks for the tip, refactored it and we are light and bright. |
mattyjones
changed the title
|
@sparrc This is complete from my point of view, if you guys have further feedback let me know. If I need anything else I will open up additional PR's to keep things clean. |
|
thanks @mattyjones! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This adds initial support for using self-signed certs. It will default to false to preserve existing functionality but can be set to
trueif desired. It also adds godoc strings where need to prevent my linter from going haywire.There are still outstanding golint issues that could be resolved. I will leave it up to the maintainers if this should be done. I would refactor it just to make the linter pass but the code that's present is more readable so I am leaving it in place.
The code changes here are functionality identical to
curl -kfor reference.At some point it would be nice to have this folded into agent as this is implemented in several plugins already and could be written in a standard manner for all plugins to use.