Removed leaked "database" tag on redis metrics #1315
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
I've found that Redis input plugin may add "database" tag on global redis stats. This is due to tags map being passed by-reference to gatherKeyspaceLine which modify it.
The result is that if you have at least one database in redis (e.g. at least one key), metric result is:
The last line should NOT contains "database=db1" since those metrics are global.
This PR make sure that database tag is not present in redis global metrics.