Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter findings for errorlint (part5) #12731

Merged
merged 4 commits into from
Mar 1, 2023
Merged

chore: Fix linter findings for errorlint (part5) #12731

merged 4 commits into from
Mar 1, 2023

Conversation

zak-pawel
Copy link
Collaborator

Address findings for errorlint - finds code that can cause problems with the error wrapping scheme introduced in Go 1.13.

It is only part of the bigger job.
After all findings in whole project are handled, we can enable errorlint linter to guard this.

Following findings in plugins/inputs/[e-m]* packages were fixed:

plugins/inputs/execd/shim/goshim.go:72:50                                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/execd/shim/goshim.go:116:52                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/execd/shim/goshim.go:153:57                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/execd/shim/goshim.go:157:70                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/fail2ban/fail2ban.go:53:55                                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/fail2ban/fail2ban.go:84:87                                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/fail2ban/fail2ban.go:105:88                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/fireboard/fireboard.go:99:64                                 errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/github/github.go:154:21                                      errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/gnmi/gnmi.go:341:54                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/gnmi/gnmi.go:345:55                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/gnmi/handler.go:65:43                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/gnmi/handler.go:76:57                                        errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/gnmi/handler.go:85:7                                         errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/gnmi/utils.go:147:61                                         errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/gnmi/utils.go:151:57                                         errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/google_cloud_storage/google_cloud_storage.go:85:6            errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/google_cloud_storage/google_cloud_storage.go:100:81          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/haproxy/haproxy.go:101:77                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/haproxy/haproxy.go:107:82                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/haproxy/haproxy.go:215:6                                     errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/http/http.go:78:50                                           errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http/http.go:160:48                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http/http.go:166:56                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http/http.go:170:51                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http/http.go:190:52                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http/http.go:196:52                                          errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http_response/http_response.go:160:25                        errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/http_response/http_response.go:165:22                        errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/http_response/http_response.go:170:21                        errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/http_response/http_response.go:172:15                        errorlint  type switch on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/http_response/http_response.go:342:93                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http_response/http_response.go:404:52                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/http_response/http_response.go:409:52                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/hugepages/hugepages.go:99:57                                 errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/hugepages/hugepages.go:105:61                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/hugepages/hugepages.go:111:60                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/hugepages/hugepages.go:163:52                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/hugepages/hugepages.go:180:55                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/influxdb_listener/influxdb_listener.go:155:6                 errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_listener/influxdb_listener.go:289:22                errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/influxdb_listener/influxdb_listener.go:312:5                 errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_listener/influxdb_listener.go:404:22                errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/influxdb_listener/influxdb_listener.go:427:5                 errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go:155:6           errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go:253:7           errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go:268:7           errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go:282:6           errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/intel_dlb/intel_dlb.go:111:89                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_dlb/intel_dlb.go:120:57                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_dlb/intel_dlb.go:308:105                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_dlb/intel_dlb.go:449:77                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_dlb/ras_reader.go:24:70                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/activators.go:99:66                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/activators.go:172:59                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/config.go:49:56                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/config.go:72:58                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/config.go:102:57                                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/config.go:127:60                                   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:131:76                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:155:72                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:160:58                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:165:67                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:170:59                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:178:86                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:182:88                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:216:66                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/intel_pmu.go:278:64                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/resolver.go:32:59                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/resolver.go:58:59                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_pmu/resolver.go:87:13                                  errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/intel_pmu/resolver.go:134:68                                 errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/file.go:35:67                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/file.go:145:79                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:88:96                                 errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:99:133                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:107:93                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:147:73                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:153:79                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:166:76                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:216:59                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/msr.go:234:83                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/rapl.go:60:100                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/rapl.go:72:96                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/rapl.go:83:113                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/rapl.go:94:109                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_powerstat/rapl.go:110:112                              errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_rdt/intel_rdt.go:338:54                                errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/intel_rdt/intel_rdt.go:350:54                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_rdt/intel_rdt.go:414:38                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/intel_rdt/intel_rdt.go:417:38                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/interrupts/interrupts.go:79:53                               errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/interrupts/interrupts.go:119:50                              errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipmi_sensor/ipmi_sensor.go:61:55                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipmi_sensor/ipmi_sensor.go:132:106                           errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipmi_sensor/ipmi_sensor.go:151:104                           errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipset/ipset.go:114:59                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipvs/ipvs.go:38:56                                           errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/ipvs/ipvs.go:47:57                                           errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jenkins/jenkins.go:87:71                                     errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jenkins/jenkins.go:121:67                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jenkins/jenkins.go:125:68                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jolokia/jolokia.go:94:66                                     errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jolokia/jolokia.go:219:60                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jolokia/jolokia.go:224:60                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jolokia2_agent/jolokia2_agent.go:54:72                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jolokia2_agent/jolokia2_agent.go:70:80                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jti_openconfig_telemetry/jti_openconfig_telemetry.go:248:8   errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/jti_openconfig_telemetry/jti_openconfig_telemetry.go:265:73  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kafka_consumer_legacy/kafka_consumer_legacy.go:117:53        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kafka_consumer_legacy/kafka_consumer_legacy.go:127:26        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kafka_consumer_legacy/kafka_consumer_legacy.go:141:69        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kafka_consumer_legacy/kafka_consumer_legacy.go:153:59        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kapacitor/kapacitor.go:52:50                                 errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kibana/kibana.go:139:54                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kubernetes/kubernetes.go:268:65                              errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/kubernetes/kubernetes.go:277:51                              errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/leofs/leofs.go:230:67                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/libvirt/libvirt.go:190:83                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/libvirt/libvirt.go:192:43                                    errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/linux_cpu/linux_cpu.go:190:92                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/linux_cpu/linux_cpu.go:207:19                                errorlint  comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/linux_cpu/linux_cpu.go:208:58                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/logstash/logstash.go:127:60                                  errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/lvm/lvm.go:63:69                                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/lvm/lvm.go:118:63                                            errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/lvm/lvm.go:182:65                                            errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/lvm/lvm.go:238:37                                            errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/marklogic/marklogic.go:136:60                                errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mem/mem.go:34:62                                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/configuration_register.go:113:73                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/configuration_request.go:142:71                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/configuration_request.go:233:73                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/modbus.go:138:50                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/modbus.go:143:57                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/modbus.go:149:55                                      errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/modbus/modbus.go:195:17                                      errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/modbus/modbus.go:340:16                                      errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/mongodb/mongodb_server.go:258:75                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mongodb/mongodb_server.go:299:58                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mongodb/mongodb_server.go:314:76                             errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/monit/monit.go:238:48                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/monit/monit_test.go:582:11                                   errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/mqtt_consumer/mqtt_consumer.go:197:36                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mqtt_consumer/mqtt_consumer.go:204:51                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:96:51                                         errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:574:95                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:671:102                                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:790:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:797:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:804:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:811:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:818:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:825:77                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:834:94                                        errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:1307:93                                       errorlint  non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
plugins/inputs/mysql/mysql.go:1472:7                                        errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
plugins/inputs/mysql/v2/convert.go:17:16                                    errorlint  type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors
plugins/inputs/mysql/v2/convert.go:17:47                                    errorlint  comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error

@telegraf-tiger telegraf-tiger bot added the chore label Feb 23, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this round @zak-pawel! I have some small questions...

plugins/inputs/http_response/http_response.go Show resolved Hide resolved
plugins/inputs/http_response/http_response.go Show resolved Hide resolved
plugins/inputs/intel_powerstat/file.go Outdated Show resolved Hide resolved
plugins/inputs/intel_rdt/intel_rdt.go Outdated Show resolved Hide resolved
plugins/inputs/monit/monit_test.go Show resolved Hide resolved
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks x5 :D

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 28, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @zak-pawel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants