Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite serializer should support output templates #925

Closed
jipperinbham opened this issue Mar 23, 2016 · 4 comments · Fixed by #1001
Closed

Graphite serializer should support output templates #925

jipperinbham opened this issue Mar 23, 2016 · 4 comments · Fixed by #1001

Comments

@jipperinbham
Copy link
Contributor

Some inputs throw a lot of tags into the metric and the graphite serializer currently defaults to iterating over every single tag in the metric to build the name. It would be nice for it to also build the name from a list of tags.

@sparrc
Copy link
Contributor

sparrc commented Mar 23, 2016

I'm going to change the name of the issue because this is something I've thought about before too, we should be able to support graphite output templates in a similar way that we already support graphite input templates.

@jipperinbham
Copy link
Contributor Author

👍 that would be quite nice, looking over the input template it's quite a bit more complicated than the current graphite serializer

@sparrc
Copy link
Contributor

sparrc commented Mar 23, 2016

yes, but I think the input needs to be quite a bit more complicated because it needs to deal with generic wildcards and mapping them into influx tag key/values. I think for output we just need to deal with explicit tag key names, and then maybe a single tag wildcard to tell it to write all the rest of the tags.

@sparrc sparrc changed the title graphite serializer shouldn't build tags from all the tags Graphite serializer should support output templates Mar 23, 2016
sparrc added a commit that referenced this issue Apr 8, 2016
sparrc added a commit that referenced this issue Apr 8, 2016
sparrc added a commit that referenced this issue Apr 8, 2016
sparrc added a commit that referenced this issue Apr 9, 2016
sparrc added a commit that referenced this issue Apr 9, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
sparrc added a commit that referenced this issue Apr 11, 2016
@jipperinbham
Copy link
Contributor Author

just checked out #1001, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants