Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Telegraf metric types: Gauge and Counter #1683

Closed
sparrc opened this issue Aug 30, 2016 · 0 comments
Closed

Support Telegraf metric types: Gauge and Counter #1683

sparrc opened this issue Aug 30, 2016 · 0 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@sparrc
Copy link
Contributor

sparrc commented Aug 30, 2016 •
edited
Loading

Feature Request

Telegraf should support different metric types. This probably only needs to be "Gauge" and "Counter", to use terms consistent with prometheus and statsd.

see https://prometheus.io/docs/concepts/metric_types/
and https://github.com/etsy/statsd/blob/master/docs/metric_types.md

Telegraf does not need to support "Histogram" types, because this is will be a separate type of streaming plugin that will aggregate a filtered set of metrics as they flow through the system (see #1662).

This will have a few benefits I can think of immediately:

  1. Protect against integer overflows in the histogram aggregator, such as those from the net input plugin.
  2. Improve prometheus output support.
  3. Open the possibility of a statsd output plugin.

There should also be an "Untyped" type, which is what all metrics will default to.
sparrc added a commit that referenced this issue Aug 30, 2016
@sparrc
Implement telegraf metric types
a261f6f 
And use them in the prometheus output plugin.

Still need to test the prometheus output plugin.

Also need to actually create typed metrics in the system plugins.

closes #1683
sparrc added a commit that referenced this issue Aug 31, 2016
@sparrc
Implement telegraf metric types
11edb64 
And use them in the prometheus output plugin.

Still need to test the prometheus output plugin.

Also need to actually create typed metrics in the system plugins.

closes #1683
sparrc added a commit that referenced this issue Aug 31, 2016
@sparrc
Implement telegraf metric types
244ad11 
And use them in the prometheus output plugin.

Still need to test the prometheus output plugin.

Also need to actually create typed metrics in the system plugins.

closes #1683
@sparrc sparrc mentioned this issue Aug 31, 2016
Merged
2 tasks
@jwilder jwilder added the feature request Requests for new plugin and for new features to existing plugins label Sep 1, 2016
@sparrc sparrc closed this as completed in 03d8abc Sep 5, 2016
jackzampolin pushed a commit that referenced this issue Oct 7, 2016
@sparrc @jackzampolin
Implement telegraf metric types
3c40c2c 
And use them in the prometheus output plugin.

Still need to test the prometheus output plugin.

Also need to actually create typed metrics in the system plugins.

closes #1683
@phemmer phemmer mentioned this issue Jan 31, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwilder @sparrc