Eliminate byte buffer, copy scanner.Bytes directly

influxdata · Apr 7, 2016 · db71e25 · db71e25
1 parent bb9a5dc
commit db71e25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/plugins/inputs/statsd/statsd_test.go b/plugins/inputs/statsd/statsd_test.go
@@ -20,7 +20,6 @@ func NewTestStatsd() *Statsd {
 	s.timings = make(map[string]cachedtimings)
 
 	s.MetricSeparator = "_"
-	s.UDPPacketSize = UDP_PACKET_SIZE
 
 	return &s
 }

diff --git a/plugins/inputs/tcp_listener/tcp_listener.go b/plugins/inputs/tcp_listener/tcp_listener.go
@@ -193,7 +193,7 @@ func (t *TcpListener) handler(conn *net.TCPConn, id string) {
 		t.forget(id)
 	}()
 
-	var buf []byte
+	var n int
 	scanner := bufio.NewScanner(conn)
 	for {
 		select {
@@ -203,12 +203,12 @@ func (t *TcpListener) handler(conn *net.TCPConn, id string) {
 			if !scanner.Scan() {
 				return
 			}
-			buf = scanner.Bytes()
-			if len(buf) == 0 {
+			n = len(scanner.Bytes())
+			if n == 0 {
 				continue
 			}
-			bufCopy := make([]byte, len(buf))
-			copy(bufCopy, buf)
+			bufCopy := make([]byte, n)
+			copy(bufCopy, scanner.Bytes())
 
 			select {
 			case t.in <- bufCopy: