only count shard if it's non-empty

closes #1221
influxdata · May 25, 2016 · 6351aa5 · 6351aa5
1 parent 9966099
commit 6351aa5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 ### Bugfixes
 
 - [#1252](https://github.com/influxdata/telegraf/pull/1252): Fix systemd service. Thanks @zbindenren!
+- [#1221](https://github.com/influxdata/telegraf/pull/1221): Fix influxdb n_shards counter.
 
 ## v0.13.1 [2016-05-24]
 

diff --git a/plugins/inputs/influxdb/influxdb.go b/plugins/inputs/influxdb/influxdb.go
@@ -204,16 +204,16 @@ func (i *InfluxDB) gatherURL(
 			continue
 		}
 
-		if p.Name == "shard" {
-			shardCounter++
-		}
-
 		// If the object was a point, but was not fully initialized,
 		// ignore it and move on.
 		if p.Name == "" || p.Tags == nil || p.Values == nil || len(p.Values) == 0 {
 			continue
 		}
 
+		if p.Name == "shard" {
+			shardCounter++
+		}
+
 		// Add a tag to indicate the source of the data.
 		p.Tags["url"] = url
 

diff --git a/plugins/inputs/influxdb/influxdb_test.go b/plugins/inputs/influxdb/influxdb_test.go
@@ -112,7 +112,7 @@ func TestInfluxDB(t *testing.T) {
 
 	acc.AssertContainsTaggedFields(t, "influxdb",
 		map[string]interface{}{
-			"n_shards": 2,
+			"n_shards": 1,
 		}, map[string]string{})
 }