Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete topic partitions #4094

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix delete topic partitions #4094

merged 1 commit into from
Jul 4, 2024

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Jul 4, 2024 •
edited
Loading

Solves: #4095

@fraidev fraidev force-pushed the fix_delete_topic_partitions branch from c733ca9 to 99a33fa Compare July 4, 2024 04:22
@fraidev fraidev marked this pull request as ready for review July 4, 2024 04:23
@fraidev fraidev requested review from sehz and digikata July 4, 2024 04:24
sehz
sehz requested changes Jul 4, 2024
View reviewed changes
crates/fluvio-sc/src/stores/topic/store.rs Outdated Show resolved Hide resolved
@fraidev fraidev force-pushed the fix_delete_topic_partitions branch from 57e2189 to 2584125 Compare July 4, 2024 06:02
sehz
sehz approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to start adding tests for controllers .

@fraidev fraidev force-pushed the fix_delete_topic_partitions branch from 2584125 to 74efed8 Compare July 4, 2024 19:43
@fraidev fraidev force-pushed the fix_delete_topic_partitions branch from 74efed8 to c2f0923 Compare July 4, 2024 19:47
@fraidev
Copy link
Contributor Author

fraidev commented Jul 4, 2024

LGTM. We need to start adding tests for controllers .

Just to let you, I put back the partition store because it's an easy way to guarantee the same SPU.
The election tests got this problem. But I also added leader checks in the unit test.

@fraidev fraidev added this pull request to the merge queue Jul 4, 2024
Merged via the queue into infinyon:master with commit a47bd8f Jul 4, 2024
104 checks passed
@fraidev fraidev deleted the fix_delete_topic_partitions branch July 4, 2024 20:47
@fraidev fraidev mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@digikata digikata Awaiting requested review from digikata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fraidev @sehz