Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tls and authorization on SC mirroring #4017

Merged
merged 1 commit into from
May 22, 2024

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented May 22, 2024

@fraidev fraidev force-pushed the mirroring_auth_2 branch 2 times, most recently from a17a334 to 44b47d3 Compare May 22, 2024 18:21
@fraidev fraidev marked this pull request as ready for review May 22, 2024 18:22
@fraidev fraidev requested a review from sehz May 22, 2024 18:22
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there E2E test? If not, it should be added

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add E2E as next step

@fraidev fraidev added this pull request to the merge queue May 22, 2024
Merged via the queue into infinyon:master with commit 4ba088a May 22, 2024
103 checks passed
@fraidev fraidev deleted the mirroring_auth_2 branch May 22, 2024 19:47
fraidev added a commit to fraidev/fluvio that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants