Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add capability to start SC on read-only mode. Read-only mode me… #3525

Closed
wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Sep 8, 2023

…ans, all write/update service endpoints are disabled.

Also added smoke test that validates that a topic cannot be created in this mode

@morenol morenol force-pushed the read-only branch 12 times, most recently from 6b1812e to c49846f Compare September 11, 2023 19:24
@morenol morenol requested a review from sehz September 11, 2023 21:56
@sehz sehz added this to the 0.10.15 milestone Sep 11, 2023
@sehz sehz added StreamController Streaming Controller k8/general labels Sep 11, 2023
@sehz
Copy link
Contributor

sehz commented Sep 11, 2023

still in draft mode

@morenol morenol marked this pull request as ready for review September 11, 2023 22:34
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. comments about using auth context rather than custom path

crates/fluvio-sc/src/services/public_api/create.rs Outdated Show resolved Hide resolved
crates/fluvio-sc/src/services/public_api/delete.rs Outdated Show resolved Hide resolved
@morenol morenol force-pushed the read-only branch 4 times, most recently from 7d51395 to 328e3bb Compare September 12, 2023 17:35
@morenol morenol requested a review from sehz September 12, 2023 18:12
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to add unit test

crates/fluvio-sc/src/services/auth/mod.rs Show resolved Hide resolved
@morenol morenol force-pushed the read-only branch 5 times, most recently from 17aec21 to 8dc8ec2 Compare September 13, 2023 19:07
@morenol morenol force-pushed the read-only branch 5 times, most recently from de53478 to a66f429 Compare September 14, 2023 17:30
@morenol morenol requested a review from sehz September 14, 2023 18:08
@morenol morenol force-pushed the read-only branch 3 times, most recently from 5d007c0 to 03064a5 Compare September 20, 2023 15:52
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. just a minor nit on githubaction

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@morenol morenol force-pushed the read-only branch 10 times, most recently from 862feb8 to 1f0603d Compare September 21, 2023 15:43
…ans, all write/update service endpoints are disabled and it runs without K8
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work

@morenol
Copy link
Contributor Author

morenol commented Sep 21, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 21, 2023
#3525)

…ans, all write/update service endpoints are disabled.

Also added smoke test that validates that a topic cannot be created in this mode
@bors
Copy link

bors bot commented Sep 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Add capability to start SC on read-only mode. Read-only mode me… [Merged by Bors] - feat: Add capability to start SC on read-only mode. Read-only mode me… Sep 21, 2023
@bors bors bot closed this Sep 21, 2023
@morenol morenol deleted the read-only branch November 1, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8/general StreamController Streaming Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants