Skip to content

Commit

Permalink
fix(example-app): remove react-native-reanimated (#1509 by @frankcalise)
Browse files Browse the repository at this point in the history
[skip ci]

## Describe your PR
- Removes `react-native-reanimated` dependency from the Example App
- Simplifies the Example App for easier contributions (in the terms of,
it's less of a headache to build, see Why)
- Tested building Android, switching between old and new arch without
any hiccups or patching that @morganick has begun to push upstream

## Why
- It's been trouble in a monorepo setting
- We don't use it in the example app, it was just from Ignite spin up
  • Loading branch information
frankcalise authored Oct 4, 2024
1 parent bb59b32 commit 1f05c7c
Show file tree
Hide file tree
Showing 3 changed files with 112 additions and 153 deletions.
9 changes: 2 additions & 7 deletions apps/example-app/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
/** @type {import('@babel/core').TransformOptions['plugins']} */
const plugins = [
/** react-native-reanimated web support @see https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#web */
"@babel/plugin-proposal-export-namespace-from",
/** NOTE: This must be last in the plugins @see https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#babel-plugin */
"react-native-reanimated/plugin",
]
const plugins = []

/** @type {import('@babel/core').TransformOptions} */
module.exports = function (api) {
api.cache(true)
return {
assumptions: {
"setPublicClassFields": true,
setPublicClassFields: true,
},
presets: ["babel-preset-expo"],
env: {
Expand Down
11 changes: 5 additions & 6 deletions apps/example-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"build:android:dev": "eas build --profile development:device --platform android --local",
"build:android:prod": "eas build --profile production --platform android --local",
"start": "npx expo start",
"android": "npx expo start --android",
"ios": "npx expo start --ios",
"android": "expo run:android",
"ios": "expo run:ios",
"web": "npx expo start --web",
"bundle:web": "npx expo export --platform web",
"serve:web": "npx server dist",
Expand All @@ -41,13 +41,13 @@
"@shopify/flash-list": "1.6.4",
"apisauce": "3.0.1",
"date-fns": "^2.30.0",
"expo": "^51.0.31",
"expo": "~51.0.36",
"expo-build-properties": "~0.12.5",
"expo-font": "~12.0.9",
"expo-font": "~12.0.10",
"expo-linear-gradient": "~13.0.2",
"expo-linking": "~6.3.1",
"expo-localization": "~15.0.3",
"expo-splash-screen": "~0.27.5",
"expo-splash-screen": "~0.27.6",
"expo-status-bar": "~1.12.1",
"i18n-js": "3.9.2",
"mobx": "6.10.2",
Expand All @@ -57,7 +57,6 @@
"react-dom": "18.2.0",
"react-native": "0.74.5",
"react-native-gesture-handler": "~2.16.1",
"react-native-reanimated": "~3.10.1",
"react-native-safe-area-context": "4.10.5",
"react-native-screens": "3.31.1",
"react-native-view-shot": "3.8.0",
Expand Down
Loading

0 comments on commit 1f05c7c

Please sign in to comment.