Fix printing in JuMP v1.11.1

[odow]

The upcoming JuMP 1.11.1 tweaks how we do printing. I'm not really sure if this is a "breaking" change or not, because it affects only the tests of InfiniteOpt, and the exact string that is printed isn't part of the API contract.

What's weird is that I couldn't reproduce the failures: jump-dev/JuMP.jl#3350 (comment)

[codecov]

Codecov Report

Merging #314 (3ad1dc8) into master (a66bbde) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          36       36           
  Lines        7099     7099           
=======================================
  Hits         7083     7083           
  Misses         16       16           

[pulsipher]

The remaining errors all stem from JuMP.check_belongs_to_model not throwing an error when expected on Julia 1.9. In particular, the following test fails:

InfiniteOpt.jl/test/point_variables.jl

Lines 350 to 357 in a66bbde

	@testset "JuMP.add_variable" begin
	# prepare secondary model and infinite variable
	m2 = InfiniteModel()
	@infinite_parameter(m2, pref3 in [0, 1])
	@variable(m2, ivref3, Infinite(pref3))
	v = build_variable(error, info, Point(ivref3, 0.5))
	# test for invalid variable error
	@test_throws VariableNotOwned{InfiniteVariableRef} add_variable(m, v)

which causes the subsequent checks to fail since a variable is unexpected added to the model at first. This test is intended to trigger the JuMP.check_belongs_to_model here:

InfiniteOpt.jl/src/point_variables.jl

Lines 423 to 432 in a66bbde

	function JuMP.add_variable(
	model::InfiniteModel,
	v::PointVariable,
	name::String = "";
	add_support = true,
	update_info = true
	)::GeneralVariableRef
	ivref = v.infinite_variable_ref
	divref = dispatch_variable_ref(ivref)
	JuMP.check_belongs_to_model(divref, model)

I am not quite sure why this is happening, but I will have some more time later to investigate.

[odow]

See #315.

I have a fix that works locally: #316

[odow]

That seems to have fixed the v1.9 issue, now the tests fail as expected because of the printing.

[odow]

So I guess the question is: are you okay if we release jump-dev/JuMP.jl#3350?

[pulsipher]

So I guess the question is: are you okay if we release jump-dev/JuMP.jl#3350?

Go ahead, no worries

[pulsipher]

Requires #316 for 1.9 tests to pass

[pulsipher]

Merging now that julia 1.6 and docs pass the testing