Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Omit instead of Exclude in router types #1857

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

aktasumut34
Copy link
Contributor

This pr fixes #1856

@driesvints driesvints requested a review from reinink April 16, 2024 08:20
@reinink reinink changed the title FIX: Router methods type issues with wrong use of Exclude Use Omit instead of Exclude in router types Apr 16, 2024
@reinink reinink merged commit 806d553 into inertiajs:master Apr 16, 2024
4 checks passed
@reinink
Copy link
Member

reinink commented Apr 16, 2024

@aktasumut34 Hey thanks! Just tested this out and you're right, that seems to work better 👍

@reinink
Copy link
Member

reinink commented Apr 16, 2024

This fix has been released as part of v1.0.16 👍

jrson83 added a commit to inertiajs-revamped/inertia that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router methods type issues with wrong use of Exclude
2 participants