Fix interface issue with useForm() in React and Vue adapters
#1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2023
|
@Spice-King Hey thanks for putting this fix together! 🤙 |
reinink
changed the title
useForm to accept interfacesuseForm
reinink
changed the title
useFormuseForm() in React and Vue adapters
|
These changes have been published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A differing attempt to fix #1624. Tested Vue2, Vue3 and React in the included playgrounds, worked fine (after setting the language to TS in the tested Vue2 page).
FormDataTypeexists so if someone wants to make a more restrictive type, it's easier for refactors.