Add displayName to Link component in React adapter
#1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinink
changed the title
displayName to Link component in React Adapter
reinink
changed the title
displayName to Link component in React AdapterdisplayName to Link component in React adapter
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the Inertia Link component doesn't have a displayName set, this doesn't cause any functional issues, but the displayName is often used by devtools to help make things a bit nicer.
The most recent example I've found of this causing issues is in Storybook -
storybookjs/storybook#20920 (comment)
If I use e.g. the Inertia Link component then it's showing as
<[Object object] href="/">This is a link</[Object object]>.While it could be argued that this is a storybook issue, other devtools also use displayName so it's an easy win for Inertia with no downsides.
We merged #351 for similar reasons.