Fix import issue with React InertiaHeadProps
type
#1460
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1448, the
InertiaHeadProps
type was updated to include React'schildren
prop.While the adapters built fine, this caused an issue when building the React playground:
Although #1448 didn't change the import of
React
inHead.ts
, the change did result in the generated types for that file now also needing to importReact
when it previously didn't.Rather than use the
allowSyntheticDefaultImports
flag, I've changed theInertiaHeadProps
type to not depend on theReact
import directly. Also, rather than manually typing thechildren
prop, I've used React'sPropsWithChildren
type which has the same end result.