Ferigis.132.implement feedback #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Feb 7, 2017
README.md
Outdated
|
|
||
| ## Feedback | ||
|
|
||
| `apns4erl` also allows us to get feedback for APNs service. It does it thru the [binary API](https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/BinaryProviderAPI.html). |
src/apns_utils.erl
Outdated
| %% Converts binary to hexadecimal string(). | ||
| -spec bin_to_hexstr(binary()) -> string(). | ||
| bin_to_hexstr(Binary) -> | ||
| L = size(Binary), |
src/apns_utils.erl
Outdated
| %% Converts from seconds to datetime. | ||
| -spec seconds_to_timestamp(pos_integer()) -> calendar:datetime(). | ||
| seconds_to_timestamp(Secs) -> | ||
| calendar:gregorian_seconds_to_datetime(Secs + 62167219200). |
There was a problem hiding this comment.
put that number in a macro or at least a variable so everybody can understand what that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[close #132]