Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update semver npm dependency to address npm audit message #2824

Closed
wants to merge 1 commit into from

Conversation

boutell
Copy link

@boutell boutell commented Jul 10, 2023

Fixes:

semver  <7.5.2
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw

Tests pass with this change in place. According to the semver changelog the 7.0 changes are small:

"Refactor module into separate files for better tree-shaking
Drop support for very old node versions, use const/let, => functions, and classes."

By "old versions" they mean very old — "engines" still only specifies 10.x or better.

@ljharb
Copy link
Member

ljharb commented Jul 10, 2023

Like most CVEs, it's a false positive. We're not using new Range nor are we doing anything that wouldn't be a self-attack (ie, not an attack).

We can't ever bump the semver version because v7 drops support for engines we support, so unless the fix is backported to v6, it'll just have to remain a false positive.

In addition, the semver team is working on a backport to v6, so all you have to do for this to be fixed is "wait".

Duplicate of #2803. Duplicate of #2804. Duplicate of #2805. Duplicate of #2806. Duplicate of #2807. Duplicate of #2808. Duplicate of #2809. Duplicate of #2810.

@ljharb ljharb closed this Jul 10, 2023
@boutell
Copy link
Author

boutell commented Jul 10, 2023 via email

@ljharb
Copy link
Member

ljharb commented Jul 10, 2023

In general, all of them - my eslint plugins rarely go below node 4, but all my other packages go down to node 0.4.

@boutell
Copy link
Author

boutell commented Jul 10, 2023

... github, where is the "awed" emoji?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants