Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deprecations): import reads from '@ember/object/computed' #227

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

gilest
Copy link
Contributor

@gilest gilest commented Jul 6, 2022

Description

Resolves deprecation id: deprecated-run-loop-and-computed-dot-access

Bug Fix

  • All existing unit tests are still passing (if applicable)
  • Add new passing unit tests to cover the code introduced by your PR
  • Update the readme
  • Update or add any necessary API documentation
  • Add some steps so we can test your bug fix
  • The PR title is in the conventional commit format: e.g. fix(<area>): fixed bug #issue-number
  • Add your info to the contributors array in package.json!

Steps to Test

Just a deprecation change. 😅 this is an intense PR template...

@gilest gilest requested a review from a team as a code owner July 6, 2022 04:59
@commit-lint
Copy link

commit-lint bot commented Jul 6, 2022

Chore

  • deprecations: import reads from '@ember/object/computed' (0c9f2a0)

Contributors

gilest

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@gilest
Copy link
Contributor Author

gilest commented Jul 28, 2022

@sherwinski @frederickfogerty could we take a look at this please?

This deprecated usage is a blocker for addon consumers wanting to upgrade to Ember v4.

Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay there @gilest, everything looks good from where I see it 👍

@sherwinski sherwinski merged commit 4bba9f9 into imgix:main Jul 28, 2022
@gilest gilest deleted the chore/computed-deprecations branch July 28, 2022 20:32
@gilest
Copy link
Contributor Author

gilest commented Jul 29, 2022

Thanks @sherwinski . Would appreciate a minor release with this patch included 🙇🏻

@sherwinski
Copy link
Contributor

@gilest Ah sorry about that, I was expecting semantic release to publish one automatically. I'll get this released for you today.

@gilest
Copy link
Contributor Author

gilest commented Aug 1, 2022

Would still be grateful for a release if that's possible 🙃

@sherwinski
Copy link
Contributor

Here you go @gilest - just published v3.0.3 🎉
Thanks for your patience on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants