fix(deps): bump to ember-get-config@1.0.0 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in consumers 0.x versions are always a pain to deal with downstream so better to use 1.x now that its out
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
@frederickfogerty I've raised this as a draft for now since |
frederickfogerty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump to ember-get-config@1.0.0 so its versioning can be managed better in consumers. Fwiw we previously allowed versions up till 0.5.0 so this only really will be bumping the minimum version required up one (which was to add better Embroider support).
0.x versions are always a pain to deal with downstream so better to use 1.x now that its out.
Steps to Test
Link to a demo app and verify ember-cli-imgix still works as intended.