Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pure Rust library instead of flate2 #2

Closed
retep998 opened this issue Jun 30, 2015 · 2 comments · Fixed by #46
Closed

Use pure Rust library instead of flate2 #2

retep998 opened this issue Jun 30, 2015 · 2 comments · Fixed by #46
Labels
discussion

Comments

@retep998
Copy link

Since png depends on flate2, which relies on miniz.c, this means that to build this crate people need to have a C/C++ compiler setup, which is annoying for users on Windows who just install Rust and expect things to work.

image-rs/image#419
@Shnatsel
Copy link
Contributor

This is also a memory safety / security concern.

Unfortunately, there doesn't seem to be a DEFLATE encoder written in Rust - "rust-compress" and "inflate" crates only provide decoders.

@ZoomRmc
Copy link

ZoomRmc commented Jun 16, 2016

What about Carol Nichols' Zopfli rewrite?
carols10cents/zopfli

@oyvindln oyvindln mentioned this issue Jan 5, 2017
Merged
bvssvni added a commit that referenced this issue Jan 6, 2017
@bvssvni
Merge pull request #46 from oyvindln/master
62f92a5 
Use deflate rather than flate2 for deflate encoding. Fixes #2
@anforowicz anforowicz mentioned this issue Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use deflate rather than flate2 for deflate encoding. Fixes #2
4 participants
@Shnatsel @retep998 @bvssvni @ZoomRmc