Change globalObject to this to prevent Node crash #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and thank you very much. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use scrollbooster (thank you for the package by the way!) in a React SSR project, with NextJS. Unfortunately, because scrollbooster wants to access the
windowproperty, Node crashes. The main problem is that the minified version of this package useswindow, so we forked the repo and changed the webpack configuration (because invoking Scrollbooster in auseEffectdid not work, nor did changing the import to src/index because it uses ES6 module syntax).If other developers want to use scrollbooster in combination with SSR, this would help them and prevent Node from crashing.